-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/nunjucks ification #302
Conversation
This is actually not easy to use. Remixing.
Having a look at this branch. Merged in the latest edits from |
hmm. I thought I added a 'list' for this in the description :( |
Converts vf-logo and vf-favicon to .nunj, as the theme expects thes
A few differences:
And then lots of the standard I think the big question is what are we gaining? Some notes:
Really, it's probably a bit of a tossup? It's probably a question of "Do we like Nunj more the Handlebars?" |
Why? Full customisation, use of "real" VF patterns, .njk file extensions. Possible 11ty integration too...
Earning all the commit points.
So we don't have to npm install and gulp for ci to get 1 css file. Depending if we stick with this or use 11ty as a pattern library, we'll need revisist.
Rethinking my closing line above:
Have investigated further over the past few days and had three areas that encourage me on this:
So, with all that in mind:
All of the patterns are working in fractal now ... with the exception of the two custom Handlebars helpers, I'm still trying to understand the syntax there. But hope to have that today at some point. In many ways this isn't urgent, but I don't think we should let it sit around too long as the merge request will get complex fast. |
This will also help with our documentation efforts: ``` {% set context = '@vf-heading' | patternContexts %} ```
…ions Feature/nunjucks extensions
@khawkins98 feel free to add and check off these.